If you are playing on an Xbox One X (not sure about the S) via backwards comparability you may find that taking a photo will cause the game to crash.
I believe this is due to the game running at 4k and the photo mode not being able to handle it.
You can get around this problem by bringing up the XBOX 360 Guide, going to the Settings tab and selecting Xbox One X Settings. In here change the option to Performance, click Yes and reload the game. Photo mode should work correctly now.
Once your done with the photo mode achievement you can change back to Graphics mode the same way.